Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/deny unknown fields #312

Merged
merged 2 commits into from
Sep 18, 2024
Merged

Fix/deny unknown fields #312

merged 2 commits into from
Sep 18, 2024

Conversation

MartinKl
Copy link
Collaborator

Toml workflow files now have to strictly conform to expected keys. Until now this behaviour was only applied in the config section of a module, i. e. using keys that map to field names, that were not valid names, they were not ignored, but denied. Unfortunately, when accidentally placing a config key outside of the config section by accident, this went unnoticed, as the outer context did not deny unknown fields. This has now been fixed.

@MartinKl MartinKl merged commit 8bbcc2b into main Sep 18, 2024
9 checks passed
@MartinKl MartinKl deleted the fix/deny-unknown-fields branch September 18, 2024 15:56
Copy link

codecov bot commented Sep 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.14%. Comparing base (517740f) to head (70a82d8).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #312   +/-   ##
=======================================
  Coverage   83.14%   83.14%           
=======================================
  Files          52       52           
  Lines       19342    19342           
  Branches    19342    19342           
=======================================
  Hits        16082    16082           
  Misses       1182     1182           
  Partials     2078     2078           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant