Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow repeated application of rules in map module #309

Merged
merged 8 commits into from
Sep 2, 2024

Conversation

thomaskrause
Copy link
Member

Also fix some issues in the xlsx importer/exporter that are necessary to convert the RIDGES corpus properly.

Copy link

codecov bot commented Sep 2, 2024

Codecov Report

Attention: Patch coverage is 89.81132% with 27 lines in your changes missing coverage. Please review.

Project coverage is 83.14%. Comparing base (e81e546) to head (0868093).
Report is 9 commits behind head on main.

Files with missing lines Patch % Lines
src/manipulator/map.rs 86.27% 2 Missing and 19 partials ⚠️
src/exporter/xlsx.rs 94.50% 2 Missing and 3 partials ⚠️
src/importer/xlsx.rs 95.23% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #309      +/-   ##
==========================================
+ Coverage   82.99%   83.14%   +0.14%     
==========================================
  Files          52       52              
  Lines       19141    19351     +210     
  Branches    19141    19351     +210     
==========================================
+ Hits        15886    16089     +203     
+ Misses       1185     1183       -2     
- Partials     2070     2079       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@thomaskrause thomaskrause merged commit dbafad5 into main Sep 2, 2024
11 checks passed
@thomaskrause thomaskrause deleted the feature/repeated-map branch September 2, 2024 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant