Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not combine multiple import updates if there is only one importer #166

Merged
merged 6 commits into from
Dec 12, 2023

Conversation

thomaskrause
Copy link
Member

No description provided.

Copy link

codecov bot commented Nov 14, 2023

Codecov Report

Attention: 46 lines in your changes are missing coverage. Please review.

Comparison is base (615cfd1) 80.27% compared to head (930cafb) 80.60%.

Files Patch % Lines
src/manipulator/merge.rs 50.00% 20 Missing and 3 partials ⚠️
src/manipulator/collapse.rs 36.36% 5 Missing and 2 partials ⚠️
src/manipulator/link.rs 14.28% 6 Missing ⚠️
src/importer/conllu/mod.rs 44.44% 5 Missing ⚠️
src/workflow.rs 85.71% 0 Missing and 3 partials ⚠️
src/bin/annatto.rs 71.42% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #166      +/-   ##
==========================================
+ Coverage   80.27%   80.60%   +0.32%     
==========================================
  Files          30       30              
  Lines       10149    10110      -39     
  Branches    10149    10110      -39     
==========================================
+ Hits         8147     8149       +2     
+ Misses        839      806      -33     
+ Partials     1163     1155       -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@thomaskrause thomaskrause marked this pull request as ready for review December 12, 2023 10:34
Because of the error handling be using StatusMessage::Failed, this is not handled properly yet.
…elying on status messages.

If you want to collect several issues and combine them in one error message, you can use the AnnattoError::ConversionFailed variant.
@thomaskrause thomaskrause merged commit 2db0ba9 into main Dec 12, 2023
9 of 10 checks passed
@thomaskrause thomaskrause deleted the feature/speed-improvements branch December 12, 2023 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants