Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tweaking adonis settings - upgrading node, removing mysql 5.7 all over #476

Merged
merged 1 commit into from
Oct 23, 2023

Conversation

fabriciojs
Copy link
Member

Issue #472
πŸͺ² Bug Fix No
🧰 Improvement Yes
πŸ† Feature No
πŸ“ Refactor No
❌ Removed No
πŸ“– Documentation No
⚠️ Break Change No

Description

  • Upgrading Node for Adonis;
  • Removing options for MySQL 5.7 as it is end-of-life.

@github-actions github-actions bot added release-drafter:changed Release drafter: Changed release-drafter:minor Release drafter: Minor labels Oct 22, 2023
@codecov
Copy link

codecov bot commented Oct 22, 2023

Codecov Report

All modified and coverable lines are covered by tests βœ…

Comparison is base (93ae19e) 73.42% compared to head (1c39d66) 73.48%.

❗ Current head 1c39d66 differs from pull request most recent head f8044f1. Consider uploading reports for the commit f8044f1 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #476      +/-   ##
==========================================
+ Coverage   73.42%   73.48%   +0.06%     
==========================================
  Files          75       75              
  Lines        2961     2961              
==========================================
+ Hits         2174     2176       +2     
+ Misses        719      716       -3     
- Partials       68       69       +1     

see 1 file with indirect coverage changes

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

@fabriciojs fabriciojs merged commit 4cab40b into main Oct 23, 2023
9 checks passed
@fabriciojs fabriciojs deleted the tweaks-adonis branch October 23, 2023 00:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-drafter:changed Release drafter: Changed release-drafter:minor Release drafter: Minor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant