This repository has been archived by the owner on Jul 12, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 33
Tests? #17
Comments
I think tests are good, but I don't see any benefit of having C++ tests in this project. This is Rust-only transpiler and having it doing only one language makes code more concise and readable. |
The way the code is structured is already a clike base class and per
language quirks. Looks like you have maintained that structure. If you want
to make it rust only (which I would not recommend) a different code
structure may make more sense.
Having some aututomated tests is my top level objective. Not breaking C++
and perhaps supporting other clike languages (I've been thinking Julia -
just for kix) is another objective.
Also related:
https://adsharma.github.io/python-622/
…On Mon, Dec 28, 2020, 7:49 AM Julian Konchunas ***@***.***> wrote:
I think tests are good, but I don't see any benefit of having C++ tests in
this project. This is Rust-only transpiler and having it doing only one
language makes code more concise and readable.
What are you trying to achieve here?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#17 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAFA2A3G4UTEI7GE4VS4G7TSXCSHVANCNFSM4USTWRKQ>
.
|
Reorganized code a bit with tests passing here. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Gives me:
What do you think about restoring the py14 code and the tests, so we can have one tree where both C++ and Rust are functional along with passing tests?
The text was updated successfully, but these errors were encountered: