Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some improvements to the rules #2

Open
dzbarsky opened this issue Feb 19, 2024 · 0 comments
Open

Some improvements to the rules #2

dzbarsky opened this issue Feb 19, 2024 · 0 comments

Comments

@dzbarsky
Copy link

Hi, just came across this and wanted to mention a few things you might want to look into (I implemented something similar my current company but we haven't open-sourced it)

Headers

Linking

  • I think the OSX linking flags are a little weird; I'm not a linking expert but my understanding is Bazel is trying to move away from those. One of the issues is they're not compatible with fixup chains. See this PR for an example
  • I haven't had time to try this yet, but I think the correct solution involves using the new cc_shared_library to control linking, vs the cc_binary + rename hack - which BTW is exactly what I did as well ;)
  • I think we'll need the cc_shared_library to depend on the Node/v8 dynamic libs but not link those in, that should give us the behavior we want. Note that this will also require exposing those on the toolchain, which we haven't done yet. A similar change was made to rules_python recently.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant