Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure we can do safe rollbacks and reverts #5

Open
ljodal opened this issue Apr 7, 2022 · 2 comments
Open

Make sure we can do safe rollbacks and reverts #5

ljodal opened this issue Apr 7, 2022 · 2 comments
Labels
enhancement New feature or request

Comments

@ljodal
Copy link
Contributor

ljodal commented Apr 7, 2022

We need a good way to disable automatic deploys, for example in this case:

  1. I commit x, it fails in prod
  2. Someone commits y
  3. I commit a revert of x, z

We don't want to even try to deploy y. Ideally the first thing we do here is to deploy x - 1, halt deploys, and then manually trigger a deploy for z once that's ready.

@ljodal
Copy link
Contributor Author

ljodal commented Apr 7, 2022

One way of solving this is to disable the workflow in GitHub, let's check if there's an API endpoint for doing this.

@thor thor added the meta/triage Issue needs additional triage or it will be closed label Aug 11, 2022
@thor
Copy link

thor commented Aug 11, 2022

⚠️ This issue needs additional triaging or it will be closed within the next few weeks. ⚠️

In particular, this issue needs issue type labels.

The issue should be labeled with either

  • feature for additional features or use-cases,
  • enhancement for smaller user-visible improvements,
  • maintenance for issues relating to technical debt or refactoring, and
  • bug for errors in behaviour as experienced by us or users.

For more information please see https://github.com/kolonialno/cloud-platform-tasks/issues/401.

@ljodal ljodal added enhancement New feature or request and removed meta/triage Issue needs additional triage or it will be closed labels Aug 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants