Skip to content
This repository has been archived by the owner on Jul 1, 2024. It is now read-only.

Offers #9

Closed
vikiival opened this issue Mar 29, 2022 · 0 comments · Fixed by #25
Closed

Offers #9

vikiival opened this issue Mar 29, 2022 · 0 comments · Fixed by #25
Milestone

Comments

@vikiival
Copy link
Member

vikiival commented Mar 29, 2022

Basically there is a ton of edge cases.

but the most crucial ones:

  • what to do with withdrawn offer? (remove or just update?)
  • what to do on accept offer? (// may status to accepted to true 🤷 )
  • add current_owner to offers? (if not removed could be nice for analytics)

ref galacticcouncil/Basilisk-node#424

@vikiival vikiival added this to the 001 milestone Mar 29, 2022
@vikiival vikiival linked a pull request May 31, 2022 that will close this issue
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant