remove support for CycloneDX SBOMs #1333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jason Hall <[email protected]>
Signed-off-by: Jason Hall <[email protected]>
cpanato
approved these changes
Jun 10, 2024
|
sorry for being out of the loop, but, can I ask why its been removed? |
|
also, this removes go modules sboms as well 🤔 |
caarlos0
added a commit
to goreleaser/goreleaser
that referenced
this pull request
Aug 9, 2024
cyclonedx and go.version-m were removed from latest ko version ko-build/ko#1333 --------- Signed-off-by: Carlos Alexandro Becker <[email protected]>
That option was never really supported or documented. As for cyclonedx, I'm not aware of any user that used it, and there were more than a few bugs in it. It seemed not worth the effort to fix them, based on usage. If you're aware of users of either of these features, let me know, we can talk about next steps for them. |
|
ah, that's fair! it was allowed on goreleaser's ko integration, but no idea if anyone used it (I have never seen). fwiw, i removed both options from goreleaser too: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.