Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: fixed install docs attestation #1099

Closed
wants to merge 1 commit into from
Closed

refactor: fixed install docs attestation #1099

wants to merge 1 commit into from

Conversation

4lch4
Copy link

@4lch4 4lch4 commented Jul 18, 2023

This PR was created as a result of #1096. @cpanato asked me to submit a PR that would fix the small documentation error I uncovered so here it is.

This PR updates the installation docs (docs/install.md) on how to install using GitHub Releases. Previously, the steps would encounter a 404 error when attempting to download the attestation.intoto.jsonl because the file was renamed to multiple.intoto.jsonl in the v0.13.0 release. Now, the documentation mentions that if you're using any version before v0.13.0 then use the previous filename but any version after (and including) v0.13.0 must use the multiple.intoto.jsonl filename instead.

Fixes: #1096

This commit updates the installation docs (`docs/install.md`) on how to install using GitHub Releases. Previously, the steps would encounter a 404 error when attempting to download the `attestation.intoto.jsonl` because the file was renamed to `multiple.intoto.jsonl` in the `v0.13.0` release. Now, the documentation mentions that if you're using any version before `v0.13.0` then use the previous filename but any version after (and including) `v0.13.0` must use the `multiple.intoto.jsonl` filename instead.
@cpanato cpanato requested a review from imjasonh July 19, 2023 07:09
Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

thank you

@codecov-commenter
Copy link

Codecov Report

Merging #1099 (b485dc4) into main (fdc4c04) will not change coverage.
The diff coverage is n/a.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@           Coverage Diff           @@
##             main    #1099   +/-   ##
=======================================
  Coverage   52.82%   52.82%           
=======================================
  Files          43       43           
  Lines        3360     3360           
=======================================
  Hits         1775     1775           
  Misses       1359     1359           
  Partials      226      226           

@github-actions
Copy link

This Pull Request is stale because it has been open for 90 days with
no activity. It will automatically close after 30 more days of
inactivity. Keep fresh with the 'lifecycle/frozen' label.

@4lch4 4lch4 closed this by deleting the head repository Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Documentation mistake
3 participants