diff --git a/pkg/build/gobuild.go b/pkg/build/gobuild.go index b5b397c31..762a4b19c 100644 --- a/pkg/build/gobuild.go +++ b/pkg/build/gobuild.go @@ -1003,6 +1003,7 @@ func (g *gobuild) buildOne(ctx context.Context, refStr string, base v1.Image, pl } } if g.debug && !doesPlatformSupportDebugging(*platform) { + log.Printf("image for platform %q will be built without debugging enabled because debugging is not supported for that platform", *platform) return nil, fmt.Errorf("debugging is not supported for %s", platform) } @@ -1116,7 +1117,7 @@ func (g *gobuild) buildOne(ctx context.Context, refStr string, base v1.Image, pl }) delvePath := "" // path for delve in image - if g.debug { + if g.debug && doesPlatformSupportDebugging(*platform) { // get delve locally delveBinary, err := getDelve(ctx, *platform) if err != nil { diff --git a/pkg/internal/git/clone.go b/pkg/internal/git/clone.go index 05a3c51ec..d87682888 100644 --- a/pkg/internal/git/clone.go +++ b/pkg/internal/git/clone.go @@ -1,3 +1,39 @@ +// Copyright 2024 ko Build Authors All Rights Reserved. +// +// Licensed under the Apache License, Version 2.0 (the "License"); +// you may not use this file except in compliance with the License. +// You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, software +// distributed under the License is distributed on an "AS IS" BASIS, +// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +// See the License for the specific language governing permissions and +// limitations under the License. + +// MIT License +// +// Copyright (c) 2016-2022 Carlos Alexandro Becker +// +// Permission is hereby granted, free of charge, to any person obtaining a copy +// of this software and associated documentation files (the "Software"), to deal +// in the Software without restriction, including without limitation the rights +// to use, copy, modify, merge, publish, distribute, sublicense, and/or sell +// copies of the Software, and to permit persons to whom the Software is +// furnished to do so, subject to the following conditions: +// +// The above copyright notice and this permission notice shall be included in all +// copies or substantial portions of the Software. +// +// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR +// IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, +// FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE +// AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER +// LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, +// OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE +// SOFTWARE. + package git import (