Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Safe-settings for peribolos investigation #3618

Open
krsna-m opened this issue Nov 15, 2022 · 3 comments
Open

Safe-settings for peribolos investigation #3618

krsna-m opened this issue Nov 15, 2022 · 3 comments
Labels
lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.

Comments

@krsna-m
Copy link
Contributor

krsna-m commented Nov 15, 2022

https://github.com/github/safe-settings is the ideal type of git-ops configuration that would be desirable https://github.com/github/safe-settings#the-settings-file. It would also be able to handle branch protection and enable repo owners to configure access to their repos by giving access to the repo subdir of the admin repo.

Setup involved https://github.com/github/safe-settings/blob/main-enterprise/docs/deploy.md deploying the app by:

  1. The public hosted version was not available at the time of evaluation so it was deployed using kubectl on GCP https://github.com/github/safe-settings/blob/main-enterprise/docs/deploy.md#deploying-using-kubectl.
  2. Then creating a github app https://github.com/settings/apps/new using the deployed app with the correct permissions https://github.com/github/safe-settings/blob/main-enterprise/docs/deploy.md#permissions. Note that the documentation and actual permission options differ. The documentation has outdated names.
  3. Create the admin repo and provide a settings file.

The org creation and management works much quicker than with peribolos. However, teams didn't seem to be implemented at the time of evaluation github/safe-settings#251 and thus does not bring us to feature parity with peribolos. Another observation is that the project seems to be lead and maintained by one person and there are quite a few things that are lacking for a more robust mature project, such as a roadmap etc.

@krsna-m
Copy link
Contributor Author

krsna-m commented Nov 15, 2022

Creating this as an issue for us to keep our eyes on if the project ever matures.

@github-actions
Copy link

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 14, 2023
@dprotaso
Copy link
Member

/lifecycle frozen

@dprotaso dprotaso reopened this Mar 20, 2023
@knative-prow knative-prow bot added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Mar 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.
Projects
None yet
Development

No branches or pull requests

2 participants