Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flaky test reporter and retryer won't work well for duplicated repo names #2107

Open
chizhg opened this issue May 20, 2020 · 3 comments
Open

Flaky test reporter and retryer won't work well for duplicated repo names #2107

chizhg opened this issue May 20, 2020 · 3 comments
Labels
bug Something isn't working kind/good-first-issue Denotes an issue ready for a new contributor. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.

Comments

@chizhg
Copy link
Member

chizhg commented May 20, 2020

When flaky test reporter generate report files, the file name will only contain the repo name, see https://github.com/knative/test-infra/blob/master/tools/flaky-test-reporter/jsonreport/jsonreport.go#L78, and flaky test retryer will only get the report with the repo name. This normally works well, but will have problems for sure if there are duplicated repo names under different orgs.

The fix would be also appending the org name in the name of the report artifact.

/bug
@chizhg chizhg added the bug Something isn't working label May 20, 2020
@github-actions
Copy link

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen.Mark the issue as
fresh by adding the comment /remove-lifecycle stale.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 18, 2020
@chizhg
Copy link
Member Author

chizhg commented Aug 18, 2020

/lifecycle frozen

@knative-prow-robot knative-prow-robot added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Aug 18, 2020
@chizhg
Copy link
Member Author

chizhg commented Sep 3, 2020

/kind good-first-issue

@knative-prow-robot knative-prow-robot added the kind/good-first-issue Denotes an issue ready for a new contributor. label Sep 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working kind/good-first-issue Denotes an issue ready for a new contributor. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@chizhg @knative-prow-robot