Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace all usages of deprecated wait.PollImmediate with wait.PollUntilContextTimeout #15067

Closed

Conversation

prashantrewar
Copy link

Fixes #14692

Proposed Changes

  • Replace usages of deprecated wait.PollImmediate with wait.PollUntilContextTimeout

Release Note

NONE

Copy link

knative-prow bot commented Mar 31, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: prashantrewar
Once this PR has been reviewed and has the lgtm label, please assign retocode for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

knative-prow bot commented Mar 31, 2024

Welcome @prashantrewar! It looks like this is your first PR to knative/serving 🎉

@knative-prow knative-prow bot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 31, 2024
Copy link

knative-prow bot commented Mar 31, 2024

Hi @prashantrewar. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow knative-prow bot requested review from ReToCode and skonto March 31, 2024 20:07
@skonto
Copy link
Contributor

skonto commented Apr 1, 2024

hi @prashantrewar these changes need to happen at the https://github.com/knative/pkg side.

@dprotaso
Copy link
Member

dprotaso commented Apr 1, 2024

Also https://github.com/knative/networking

Once those repos are updated we have automation to pull in the changes.

@dprotaso dprotaso closed this Apr 1, 2024
@dprotaso
Copy link
Member

dprotaso commented Apr 1, 2024

Note the vendor folder is a golang convention for vendoring - see: https://go.dev/ref/mod#vendoring

@prashantrewar prashantrewar deleted the replace-wait.PollImmediate branch April 1, 2024 17:00
@prashantrewar
Copy link
Author

prashantrewar commented Apr 1, 2024

Hey @skonto and @dprotaso, I create a PR in https://github.com/knative/pkg. Please take a look.

@prashantrewar
Copy link
Author

Also https://github.com/knative/networking

Once those repos are updated we have automation to pull in the changes.

Hey @dprotaso and @skonto, I created a PR in https://github.com/knative/networking also. Please take a look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix all lint warnings
3 participants