Use InternalTLSEnabled() instead of internal-encryption

[nak3]

This patch changes to use InternalTLSEnabled() instead of internal-encryption to verify config key.

Release Note

NOE

[nak3]

/hold

We need to fix networking repo. Current PR is for demonstrating the error.

[nak3]

The unit test should be fixed once knative/networking#847 was fixed.

[ReToCode]

I like the idea, but do we want to reopen the discussion on having those flags with those settings first? Context: https://cloud-native.slack.com/archives/C04LGJ0D5FF/p1690967287198279?thread_ts=1688403244.113969&cid=C04LGJ0D5FF.

WDYT @KauzClay ?

[nak3]

We can keep using the InternalTLSEnabled() even if the discussion will be accepted and the internal logic will be changed. So, I think it is not necessary to wait for the outcome of the discussion?

[ReToCode]

Good point, let's do that.

[codecov]

Codecov Report

Patch and project coverage have no change.

Comparison is base (43f7526) 86.23% compared to head (e2e8264) 86.23%.
Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #14301   +/-   ##
=======================================
  Coverage   86.23%   86.23%           
=======================================
  Files         195      195           
  Lines       14702    14702           
=======================================
+ Hits        12678    12679    +1     
  Misses       1723     1723           
+ Partials      301      300    -1     

Files Changed	Coverage Δ
cmd/activator/main.go	0.00% <0.00%> (ø)
pkg/reconciler/revision/resources/deploy.go	90.13% <0.00%> (ø)
pkg/reconciler/revision/revision.go	92.13% <0.00%> (ø)

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[nak3]

/hold cancel

This is ready now.

[ReToCode]

/lgtm

[knative-prow]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nak3, ReToCode

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [nak3]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment