Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add app: webhook label to webhook service #14258

Merged
merged 1 commit into from
Aug 15, 2023

Conversation

JordanDeBeer
Copy link
Contributor

Fixes #

Proposed Changes

  • Add an app label to the webhook service. This aligns with the other component services (activator, controller).

Release Note

Label the webhook service with "app: webhook" label

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Aug 14, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: JordanDeBeer / name: Jordan DeBeer (c6b5bca)

@knative-prow
Copy link

knative-prow bot commented Aug 14, 2023

Welcome @JordanDeBeer! It looks like this is your first PR to knative/serving 🎉

@knative-prow knative-prow bot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 14, 2023
@knative-prow
Copy link

knative-prow bot commented Aug 14, 2023

Hi @JordanDeBeer. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow knative-prow bot requested review from KauzClay and skonto August 14, 2023 15:58
@dprotaso
Copy link
Member

/ok-to-test
/lgtm
/approve

@knative-prow knative-prow bot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Aug 14, 2023
@knative-prow knative-prow bot added lgtm Indicates that a PR is ready to be merged. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 14, 2023
@knative-prow
Copy link

knative-prow bot commented Aug 14, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, JordanDeBeer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 14, 2023
@codecov
Copy link

codecov bot commented Aug 14, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.03% ⚠️

Comparison is base (ece2fea) 86.28% compared to head (c6b5bca) 86.26%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #14258      +/-   ##
==========================================
- Coverage   86.28%   86.26%   -0.03%     
==========================================
  Files         199      199              
  Lines       14811    14811              
==========================================
- Hits        12780    12776       -4     
- Misses       1730     1734       +4     
  Partials      301      301              

see 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@knative-prow knative-prow bot merged commit 6bfe5c3 into knative:main Aug 15, 2023
58 of 59 checks passed
@JordanDeBeer JordanDeBeer deleted the add-app-label branch August 15, 2023 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants