Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bubble up KCertificate Status Message when its not ready #14257

Conversation

xtreme-vikram-yadav
Copy link

@xtreme-vikram-yadav xtreme-vikram-yadav commented Aug 14, 2023

Fixes #14250

Proposed Changes

  • KCert Status Message gets bubbled up to its parent Route when it's not ready

Reproduction Steps

  • Given a cluster with Knative serving and autoTLS enabled
  • And the domain is configured so that the generated URL contains more than 64 Bytes (Command: kubectl edit configmap config-domain -n knative-serving)
  • When a Knative service is created
  • Then I should see the Certificate generation error in the status of the Knative Service and Route.

OR

Run this script against a local kind cluster.
Note: Update KO_DOCKER_REPO before running the above script.

Release Note

* Certificate generation errors are bubbled up to its parent Route.

@knative-prow knative-prow bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. area/API API objects and controllers area/networking area/test-and-release It flags unit/e2e/conformance/perf test issues for product features labels Aug 14, 2023
@codecov
Copy link

codecov bot commented Aug 14, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.14% ⚠️

Comparison is base (f9d9b28) 86.25% compared to head (a7fcdc2) 86.12%.
Report is 114 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #14257      +/-   ##
==========================================
- Coverage   86.25%   86.12%   -0.14%     
==========================================
  Files         199      196       -3     
  Lines       14811    14792      -19     
==========================================
- Hits        12775    12739      -36     
- Misses       1734     1746      +12     
- Partials      302      307       +5     
Files Changed Coverage Δ
pkg/apis/serving/v1/route_lifecycle.go 100.00% <100.00%> (ø)
pkg/reconciler/route/route.go 79.70% <100.00%> (ø)

... and 14 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@nak3 nak3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one nit otherwise LGTM.

pkg/apis/serving/v1/route_lifecycle.go Outdated Show resolved Hide resolved
@nak3
Copy link
Contributor

nak3 commented Aug 16, 2023

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Aug 16, 2023
pkg/apis/serving/v1/route_lifecycle_test.go Outdated Show resolved Hide resolved
pkg/apis/serving/v1/route_lifecycle.go Show resolved Hide resolved
pkg/apis/serving/v1/route_lifecycle.go Show resolved Hide resolved
@knative-prow knative-prow bot removed the lgtm Indicates that a PR is ready to be merged. label Aug 29, 2023
@knative-prow
Copy link

knative-prow bot commented Sep 21, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: xtreme-vikram-yadav
Once this PR has been reviewed and has the lgtm label, please ask for approval from dprotaso. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dprotaso
Copy link
Member

Closing as Vikram is on a pretty long vacation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/API API objects and controllers area/networking area/test-and-release It flags unit/e2e/conformance/perf test issues for product features size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Kcert errors should bubble to Knative Service
3 participants