-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bubble up KCertificate Status Message when its not ready #14257
Bubble up KCertificate Status Message when its not ready #14257
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #14257 +/- ##
==========================================
- Coverage 86.25% 86.12% -0.14%
==========================================
Files 199 196 -3
Lines 14811 14792 -19
==========================================
- Hits 12775 12739 -36
- Misses 1734 1746 +12
- Partials 302 307 +5
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one nit otherwise LGTM.
a9a67c7
to
171f1f9
Compare
/lgtm |
171f1f9
to
a7fcdc2
Compare
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: xtreme-vikram-yadav The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Closing as Vikram is on a pretty long vacation |
Fixes #14250
Proposed Changes
Reproduction Steps
OR
Run this script against a local kind cluster.
Note: Update
KO_DOCKER_REPO
before running the above script.Release Note