Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support to use vegeta client with HTTPS #14255

Merged
merged 1 commit into from
Aug 14, 2023

Conversation

nak3
Copy link
Contributor

@nak3 nak3 commented Aug 14, 2023

e2e test supports --https option but vegeta client always uses "HTTP".
This patch supports https wit so vegeta uses TLS client.

Release Note

NONE

@knative-prow
Copy link

knative-prow bot commented Aug 14, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nak3

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. area/test-and-release It flags unit/e2e/conformance/perf test issues for product features labels Aug 14, 2023
@nak3
Copy link
Contributor Author

nak3 commented Aug 14, 2023

/test foo

@knative-prow
Copy link

knative-prow bot commented Aug 14, 2023

@nak3: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test build-tests
  • /test contour-latest
  • /test contour-tls
  • /test gateway-api-latest
  • /test istio-latest-no-mesh
  • /test istio-latest-no-mesh-tls
  • /test kourier-stable
  • /test kourier-stable-tls
  • /test unit-tests
  • /test upgrade-tests

The following commands are available to trigger optional jobs:

  • /test https
  • /test istio-latest-mesh
  • /test istio-latest-mesh-short
  • /test istio-latest-mesh-tls
  • /test performance-tests-kperf
  • /test performance-tests-mako

Use /test all to run the following jobs that were automatically triggered:

  • build-tests_serving_main
  • istio-latest-no-mesh-tls_serving_main
  • istio-latest-no-mesh_serving_main
  • unit-tests_serving_main
  • upgrade-tests_serving_main

In response to this:

/test foo

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@nak3
Copy link
Contributor Author

nak3 commented Aug 14, 2023

/test https

@codecov
Copy link

codecov bot commented Aug 14, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.01% 🎉

Comparison is base (f9d9b28) 86.25% compared to head (ad447b4) 86.26%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #14255      +/-   ##
==========================================
+ Coverage   86.25%   86.26%   +0.01%     
==========================================
  Files         199      199              
  Lines       14811    14811              
==========================================
+ Hits        12775    12777       +2     
+ Misses       1734     1732       -2     
  Partials      302      302              

see 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nak3 nak3 added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 14, 2023
e2e test supports `--https` option but vegeta client always uses "HTTP".
This patch supports https wit so vegeta uses TLS client.
@nak3
Copy link
Contributor Author

nak3 commented Aug 14, 2023

/retest

Infra issue All cluster resources were brought up, but: only 8 nodes out of 12 have registered; cluster may be unhealthy.

@nak3 nak3 removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 14, 2023
@krsna-m
Copy link
Contributor

krsna-m commented Aug 14, 2023

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Aug 14, 2023
@knative-prow knative-prow bot merged commit 5c1c855 into knative:main Aug 14, 2023
63 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release It flags unit/e2e/conformance/perf test issues for product features lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants