Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP]Poc for the progressive rollout #14237

Closed
wants to merge 11 commits into from

Conversation

houshengbo
Copy link
Contributor

Fixes #

Proposed Changes

Release Note


@knative-prow knative-prow bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 7, 2023
@knative-prow knative-prow bot requested review from ReToCode and skonto August 7, 2023 14:59
@knative-prow knative-prow bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. area/API API objects and controllers area/autoscale labels Aug 7, 2023
@knative-prow
Copy link

knative-prow bot commented Aug 7, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: houshengbo
Once this PR has been reviewed and has the lgtm label, please assign psschwei for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow
Copy link

knative-prow bot commented Aug 28, 2023

@houshengbo: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
unit-tests_serving_main 534f9c8 link true /test unit-tests
build-tests_serving_main 534f9c8 link true /test build-tests
istio-latest-no-mesh-tls_serving_main 534f9c8 link true /test istio-latest-no-mesh-tls
istio-latest-no-mesh_serving_main 534f9c8 link true /test istio-latest-no-mesh
upgrade-tests_serving_main 534f9c8 link true /test upgrade-tests

Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@dprotaso
Copy link
Member

dprotaso commented Aug 29, 2023

Going to close this out based on the discussion from the last serving wg meeting

From the notes:

The thinking here is Service is a convenient high level resource (for users) that will manage a Configuration and Route. In the past we’ve encouraged custom orchestrators to use Configuration and Route directly. I don’t think we want Service to have different rollout types because it will increase complexity. Thus creating a sibling resource that users can use as an alternative to Service - that can be paired with a custom autoscaler is probably the best approach to start.
Doing this as experiment in the knative-extensions repo would be a great place to do this and I (Dave) would sponsor this

@dprotaso dprotaso closed this Aug 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/API API objects and controllers area/autoscale do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants