Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Automated] Update net-kourier nightly #14209

Merged

Conversation

knative-automation
Copy link
Contributor

/assign @knative/serving-writers
/cc @knative/serving-writers

Produced via:

for x in kourier.yaml; do
  curl https://storage.googleapis.com/knative-nightly/net-kourier/latest/$x > ${GITHUB_WORKSPACE}/./third_party/kourier-latest/$x
done

Details:

bumping knative.dev/net-kourier 2a2db6d...1396d30:
  > 1396d30 Update actions (# 1083)
  > 45833a2 Update community files (# 1082)

bumping knative.dev/net-kourier 2a2db6d...1396d30:
  > 1396d30 Update actions (# 1083)
  > 45833a2 Update community files (# 1082)

Signed-off-by: Knative Automation <[email protected]>
@knative-prow knative-prow bot requested a review from a team August 2, 2023 11:05
@knative-prow knative-prow bot added area/networking size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 2, 2023
@codecov
Copy link

codecov bot commented Aug 2, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.02% 🎉

Comparison is base (e937b62) 86.18% compared to head (5dce5ef) 86.20%.
Report is 7 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #14209      +/-   ##
==========================================
+ Coverage   86.18%   86.20%   +0.02%     
==========================================
  Files         199      199              
  Lines       14811    14811              
==========================================
+ Hits        12765    12768       +3     
+ Misses       1741     1738       -3     
  Partials      305      305              

see 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@knative-prow
Copy link

knative-prow bot commented Aug 2, 2023

@Khademr7: changing LGTM is restricted to collaborators

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow knative-prow bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 2, 2023
@psschwei
Copy link
Contributor

psschwei commented Aug 2, 2023

/test kourier-stable

1 similar comment
@psschwei
Copy link
Contributor

psschwei commented Aug 2, 2023

/test kourier-stable

@nak3
Copy link
Contributor

nak3 commented Aug 3, 2023

/retest

@nak3
Copy link
Contributor

nak3 commented Aug 3, 2023

error log:

    destroypod_test.go:151: Something went wrong with the request: response: <nil> did not pass checks: unexpected EOF

The net-kourier's change should not effect on serving...

bumping knative.dev/net-kourier 2a2db6d...1396d30:
  > 1396d30 Update actions (# 1083)
  > 45833a2 Update community files (# 1082)

@nak3
Copy link
Contributor

nak3 commented Aug 3, 2023

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Aug 3, 2023
@knative-prow
Copy link

knative-prow bot commented Aug 3, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Khademr7, knative-automation, nak3

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 3, 2023
@knative-prow knative-prow bot merged commit e7c66a8 into knative:main Aug 3, 2023
59 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/networking lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants