Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Stringer for nil podTracker #14147

Merged
merged 1 commit into from
Jul 7, 2023

Conversation

evankanderson
Copy link
Member

Proposed Changes

  • Implement the Stringer interface for nil podTrackers. This sometimes causes spurious fuzzing failures when printing / comparing podTrackers.

@knative-prow knative-prow bot added area/autoscale area/networking size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 6, 2023
@knative-prow knative-prow bot requested review from krsna-m and ReToCode July 6, 2023 06:47
@codecov
Copy link

codecov bot commented Jul 6, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.04 ⚠️

Comparison is base (bde2f42) 86.23% compared to head (f886195) 86.20%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #14147      +/-   ##
==========================================
- Coverage   86.23%   86.20%   -0.04%     
==========================================
  Files         199      199              
  Lines       14795    14798       +3     
==========================================
- Hits        12759    12756       -3     
- Misses       1733     1736       +3     
- Partials      303      306       +3     
Impacted Files Coverage Δ
pkg/activator/net/throttler.go 87.87% <100.00%> (+0.07%) ⬆️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@dprotaso
Copy link
Member

dprotaso commented Jul 7, 2023

Curious what kind of fuzzing are you doing?

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jul 7, 2023
@knative-prow
Copy link

knative-prow bot commented Jul 7, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, evankanderson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 7, 2023
@knative-prow knative-prow bot merged commit 4ccd1c9 into knative:main Jul 7, 2023
55 checks passed
skonto pushed a commit to skonto/serving that referenced this pull request Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/autoscale area/networking lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants