Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Automated] Update net-certmanager nightly #14145

Conversation

knative-automation
Copy link
Contributor

@knative-automation knative-automation commented Jul 5, 2023

/assign @knative/serving-writers
/cc @knative/serving-writers

Produced via:

for x in net-certmanager.yaml; do
  curl https://storage.googleapis.com/knative-nightly/net-certmanager/latest/$x > ${GITHUB_WORKSPACE}/./third_party/cert-manager-latest/$x
done

Details:

bumping knative.dev/net-certmanager 3ff3c98...f0a5aa1:
  > f0a5aa1 read buildinfo go runtime vs ko (# 555)
  > d6805af Add the ability to create `cluster-local` certificates by an internal cert-issuer (# 538)

@knative-prow knative-prow bot requested a review from a team July 5, 2023 11:06
@knative-prow
Copy link

knative-prow bot commented Jul 5, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: knative-automation
Once this PR has been reviewed and has the lgtm label, please assign psschwei for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added area/networking size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 5, 2023
@codecov
Copy link

codecov bot commented Jul 5, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (ebbca26) 86.23% compared to head (c380190) 86.23%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #14145   +/-   ##
=======================================
  Coverage   86.23%   86.23%           
=======================================
  Files         199      199           
  Lines       14795    14795           
=======================================
  Hits        12759    12759           
+ Misses       1734     1733    -1     
- Partials      302      303    +1     

see 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ReToCode
Copy link
Member

ReToCode commented Jul 6, 2023

/hold

@knative-prow knative-prow bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 6, 2023
bumping knative.dev/net-certmanager 3ff3c98...f0a5aa1:
  > f0a5aa1 read buildinfo go runtime vs ko (# 555)
  > d6805af Add the ability to create `cluster-local` certificates by an internal cert-issuer (# 538)

Signed-off-by: Knative Automation <[email protected]>
@knative-prow
Copy link

knative-prow bot commented Jul 7, 2023

@knative-automation: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
upgrade-tests_serving_main c380190 link true /test upgrade-tests
istio-latest-no-mesh-tls_serving_main c380190 link true /test istio-latest-no-mesh-tls
istio-latest-no-mesh_serving_main c380190 link true /test istio-latest-no-mesh
https_serving_main c380190 link false /test https

Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@dprotaso
Copy link
Member

dprotaso commented Jul 7, 2023

@ReToCode are you looking into the failures?

@ReToCode
Copy link
Member

Yes, they were caused by my changes here. Although I do not yet get why this even happens.

@skonto if I cannot fix it until the cut of net-certmanager, I'll revert the commit there and re-add it after the release cut.

@ReToCode
Copy link
Member

Incorporated in #14148.

@ReToCode ReToCode closed this Jul 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/networking do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants