Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drop special logic when handling kubelet probe header for istio mTLS #2997

Merged
merged 1 commit into from
May 29, 2024

Conversation

izabelacg
Copy link
Member

Changes

  • Deprecates k-kubelet-probe header

Part of knative/serving#14981

@knative-prow knative-prow bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 25, 2024
@knative-prow knative-prow bot requested review from ReToCode and skonto March 25, 2024 21:52
Copy link

codecov bot commented Mar 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.70%. Comparing base (fd7cc21) to head (5844df8).
Report is 43 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2997      +/-   ##
==========================================
- Coverage   78.70%   78.70%   -0.01%     
==========================================
  Files         188      188              
  Lines       11051    11050       -1     
==========================================
- Hits         8698     8697       -1     
  Misses       2090     2090              
  Partials      263      263              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@izabelacg izabelacg changed the title [WIP] drop special logic when handling kubelet probe header for istio mTLS drop special logic when handling kubelet probe header for istio mTLS Mar 25, 2024
@knative-prow knative-prow bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 25, 2024
@knative-prow knative-prow bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 25, 2024
@dprotaso
Copy link
Member

dprotaso commented Mar 26, 2024

This is a breaking change and not something we want.

The serving issue is about removing the bit of code where we set the header on the deployment readiness/liveness etc.

The kubelet that does the proxying still adds this user agent so we still need to handle them accordingly.

@dprotaso
Copy link
Member

dprotaso commented Mar 26, 2024

Circling back - I misread the PR (early morning reviews are bad for me)

The changes in the PR are good but I think we should merge them after the deployment changes have been around for a release. So this should land for 1.15

See details here: knative/networking#950 (comment)

/hold

@dprotaso dprotaso reopened this Mar 26, 2024
@knative-prow knative-prow bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 26, 2024
@dprotaso dprotaso added this to the v1.15.0 milestone Mar 26, 2024
@dprotaso
Copy link
Member

/retest
/unhold

@knative-prow knative-prow bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 29, 2024
@dprotaso
Copy link
Member

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label May 29, 2024
Copy link

knative-prow bot commented May 29, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, izabelacg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 29, 2024
@dprotaso
Copy link
Member

/retest
unrelated failure

{Failed  === RUN   TestNamespaceStream
    stream_test.go:316: Log was still produced, trying again...
    stream_test.go:323: No watching should have happened context canceled
--- FAIL: TestNamespaceStream (0.41s)
}

@knative-prow knative-prow bot merged commit 7d52a43 into knative:main May 29, 2024
73 of 74 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
Development

Successfully merging this pull request may close these issues.

2 participants