-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix runtime image probe handler setup #963
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dprotaso The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
can you share how to reproduce the issue? I curled the service (original) in different paths with the user-agent header and seems to work as expected. I get the following:
|
When you curl with the eg.
Should also work when you are not using the
|
If you're running this image with Knative Service then you won't reproduce original issue These pods don't run with the queue proxy sidecar in the conformance tests - so it's replicating that. |
Thanks for the explanation. I got to see the issue and solution working. |
/lgtm |
While working on knative-extensions/net-gateway-api#18
I discovered the runtime image in this repository doesn't behave like the queue proxy. The probe handler should work with any URL path but this image it only works when the path is
/healthz
The change in the PR changes the handler setup so the probe handler is first. This is what the other networking images do.
/assign @izabelacg