Replace all usages of deprecated wait.PollImmediate with wait.PollUntilContextTimeout

[prashantrewar]

Changes

• Replace usages of deprecated wait.PollImmediate with wait.PollUntilContextTimeout

/kind

Fixes #

Release Note

NONE

Docs

[knative-prow]

@prashantrewar: The label(s) kind/<kind> cannot be applied, because the repository doesn't have them.

In response to this:

Changes

• Replace usages of deprecated wait.PollImmediate with wait.PollUntilContextTimeout

/kind

Fixes #

Release Note

NONE

Docs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[knative-prow]

Welcome @prashantrewar! It looks like this is your first PR to knative/networking 🎉

[knative-prow]

Hi @prashantrewar. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[dprotaso]

/ok-to-test

[dprotaso]

I believe the test is failing because wait.ErrWaitTimeout is not longer returned by these new functions

networking/pkg/prober/prober_test.go

Lines 227 to 229 in 13c6ea7

	if !errors.Is(err, wait.ErrWaitTimeout) {
	t.Error("Unexpected error =", err)
	}

According to the docs https://pkg.go.dev/k8s.io/apimachinery/pkg/util/wait#Poll

Note that the new method will no longer return ErrWaitTimeout and instead return errors defined by the context package. Will be removed in a future release.

[dprotaso]

You'll also need to verify if wait.ErrWaitTimeout is used anywhere in the serving/net- repo and update those accordingly.

[dprotaso]

I don't think it's used anywhere in code that isn't tests so I think we should be ok

[ReToCode]

/retest

[ReToCode]

/test unit-tests

[ReToCode]

@prashantrewar mind taking a look at the test failures?

[dprotaso]

@prashantrewar just following up - are you able to address the unit test failures?

[prashantrewar]

@prashantrewar just following up - are you able to address the unit test failures?

@dprotaso, I tried, and I found that wait.ErrWaitTimeout is also deprecated, which is why the test failed. Should I replace this also?

[dprotaso]

Should I replace this also?

Yeah update the test

[prashantrewar]

Should I replace this also?

Yeah update the test

@dprotaso Done!

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.41%. Comparing base (75762ca) to head (9af1ce7).
Report is 7 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #957      +/-   ##
==========================================
- Coverage   93.43%   93.41%   -0.02%     
==========================================
  Files          36       36              
  Lines        1249     1003     -246     
==========================================
- Hits         1167      937     -230     
+ Misses         69       53      -16     
  Partials       13       13              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[dprotaso]

/retest

[dprotaso]

/lgtm
/approve

thanks @prashantrewar

[knative-prow]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, prashantrewar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [dprotaso]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[prashantrewar]

Thank you @dprotaso for guidance and support.