Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[main] Upgrade to latest dependencies #907

Merged

Conversation

knative-automation
Copy link
Contributor

Cron -knative-prow-robot

/cc knative/serving-writers
/assign knative/serving-writers

Produced by: knative-extensions/knobots/actions/update-deps

bumping knative.dev/pkg 697d669...de3e9cc:
  > de3e9cc Fixing all deprecated use of sets.String (# 2915)
  > a65a9e2 lower log level for AdmissionController.Admit validation  failures (# 2905)
  > 4c06610 Update community files (# 2929)
bumping knative.dev/hack 7030d5b...3ea694d:
  > 3ea694d include additional k8s bash file when updating exec permission (# 357)
  > 2f27d6e Update community files (# 356)

Signed-off-by: Knative Automation <[email protected]>
@knative-prow knative-prow bot requested a review from a team January 9, 2024 01:30
@knative-prow knative-prow bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 9, 2024
Copy link

codecov bot commented Jan 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7cca4b0) 82.18% compared to head (74310ca) 82.18%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #907   +/-   ##
=======================================
  Coverage   82.18%   82.18%           
=======================================
  Files          46       46           
  Lines        1746     1746           
=======================================
  Hits         1435     1435           
  Misses        268      268           
  Partials       43       43           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@ReToCode ReToCode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jan 9, 2024
Copy link

knative-prow bot commented Jan 9, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: knative-automation, ReToCode

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 9, 2024
@ReToCode
Copy link
Member

ReToCode commented Jan 9, 2024

/override "Downstream / Unit Test (knative-extensions/net-kourier)"

I'm working on a followup-PR to fix those.

Copy link

knative-prow bot commented Jan 9, 2024

@ReToCode: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

  • Downstream / Unit Test (knative-extensions/net-kourier)

Only the following failed contexts/checkruns were expected:

  • EasyCLA
  • Unit Test (knative-extensions/net-kourier)
  • Unit Test (knative/serving)
  • build-tests_networking_main
  • integration-tests_networking_main
  • style / suggester / github_actions
  • style / suggester / yaml
  • tide
  • unit-tests_networking_main

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

In response to this:

/override "Downstream / Unit Test (knative-extensions/net-kourier)"

I'm working on a followup-PR to fix those.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ReToCode
Copy link
Member

ReToCode commented Jan 9, 2024

/override "Unit Test (knative-extensions/net-kourier)"

Copy link

knative-prow bot commented Jan 9, 2024

@ReToCode: Overrode contexts on behalf of ReToCode: Unit Test (knative-extensions/net-kourier)

In response to this:

/override "Unit Test (knative-extensions/net-kourier)"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ReToCode
Copy link
Member

ReToCode commented Jan 9, 2024

/override "Unit Test (knative/serving)"

Copy link

knative-prow bot commented Jan 9, 2024

@ReToCode: Overrode contexts on behalf of ReToCode: Unit Test (knative/serving)

In response to this:

/override "Unit Test (knative/serving)"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow knative-prow bot merged commit 964fcff into knative:main Jan 9, 2024
28 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants