Improve InternalTLSEnabled util function #847
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently `InternalTLSEnabled()` has two issues such as: * `true` is returned when `dataplane-trust` is not configured. * `controlplane-trust` is not considered. This patch improves these issues.
knative-prow
bot
added
kind/enhancement
approved
knative-prow
bot
added
the
size/S
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #847 +/- ##
==========================================
- Coverage 82.50% 82.26% -0.24%
==========================================
Files 45 45
Lines 1715 1720 +5
==========================================
Hits 1415 1415
- Misses 259 264 +5
Partials 41 41
☔ View full report in Codecov by Sentry. |
nak3
force-pushed
the
fix-internal-encryption
branch
from
496cb74
to
d0624a4
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nak3, ReToCode The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
InternalTLSEnabled()has two issues such as:trueis returned whendataplane-trustis not configured. (The current default isdisabled.)controlplane-trustis not considered.This patch improves these issues.
/kind enhancement
Release Note