Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[main] Upgrade to latest dependencies #828

Conversation

knative-automation
Copy link
Contributor

Cron -knative-prow-robot

/cc knative/serving-writers
/assign knative/serving-writers

Produced by: knative-sandbox/knobots/actions/update-deps

Signed-off-by: Knative Automation <[email protected]>
@knative-prow knative-prow bot requested a review from a team July 25, 2023 13:12
@knative-prow knative-prow bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 25, 2023
@knative-prow
Copy link

knative-prow bot commented Jul 25, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: knative-automation
Once this PR has been reviewed and has the lgtm label, please assign dsimansk for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link

codecov bot commented Jul 25, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (75dcd54) 82.84% compared to head (1c0c329) 82.84%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #828   +/-   ##
=======================================
  Coverage   82.84%   82.84%           
=======================================
  Files          45       45           
  Lines        1708     1708           
=======================================
  Hits         1415     1415           
  Misses        252      252           
  Partials       41       41           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nak3
Copy link
Contributor

nak3 commented Jul 26, 2023

/close

I think this does not need to merge as it is a permission change.
In fact, github action fails https://github.com/knative/networking/actions/runs/5657253302/job/15325904609?pr=828

@knative-prow
Copy link

knative-prow bot commented Jul 26, 2023

@nak3: Closed this PR.

In response to this:

/close

I think this does not need to merge as it is a permission change.
In fact, github action fails https://github.com/knative/networking/actions/runs/5657253302/job/15325904609?pr=828

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow knative-prow bot closed this Jul 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants