Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump google.golang.org/grpc to the latest version #821

Merged
merged 1 commit into from
Jul 7, 2023

Conversation

nak3
Copy link
Contributor

@nak3 nak3 commented Jul 6, 2023

This patch replaces #820.

google.golang.org/grpc is used only by test code so it does not effect but we should avoid the security alert.

/cc @dprotaso @ReToCode

@knative-prow knative-prow bot requested review from dprotaso and ReToCode July 6, 2023 01:49
@knative-prow knative-prow bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 6, 2023
@codecov
Copy link

codecov bot commented Jul 6, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (91821ae) 82.84% compared to head (f3d0ca7) 82.84%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #821   +/-   ##
=======================================
  Coverage   82.84%   82.84%           
=======================================
  Files          45       45           
  Lines        1708     1708           
=======================================
  Hits         1415     1415           
  Misses        252      252           
  Partials       41       41           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@nak3
Copy link
Contributor Author

nak3 commented Jul 7, 2023

/cc @KauzClay

@knative-prow knative-prow bot requested a review from KauzClay July 7, 2023 00:48
@dprotaso
Copy link
Member

dprotaso commented Jul 7, 2023

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jul 7, 2023
@knative-prow
Copy link

knative-prow bot commented Jul 7, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, nak3

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit 1431d70 into knative:main Jul 7, 2023
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants