From 419ebf9a1d87e4c24b2c0ce3533dc5b1b2ba3aca Mon Sep 17 00:00:00 2001 From: Izabela Gomes Date: Tue, 26 Mar 2024 16:09:06 -0400 Subject: [PATCH] Drop special logic for kubelet probe header for istio (#950) * drop special logic for kubelet probe header for istio * fix tests * add header back * address feedback --- pkg/http/header/header.go | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/pkg/http/header/header.go b/pkg/http/header/header.go index 158fb0620..143f8bedb 100644 --- a/pkg/http/header/header.go +++ b/pkg/http/header/header.go @@ -55,9 +55,14 @@ const ( // at the Queue proxy level back to be a host header. OriginalHostKey = "K-Original-Host" - // KubeletProbeKey is the name of the header supplied by kubelet - // probes. Istio with mTLS rewrites probes, but their probes pass a - // different user-agent. So we augment the probes with this header. + // KubeletProbeKey is the name of the header supplied by kubelet probes. + // Prior to this deprecation, Istio with mTLS rewrote probes and their probes passed a + // different user-agent. Therefore, this header was added to augment the probes. + // + // Deprecated: this custom request header is no longer necessary since Istio now propagates the + // original request header `User-Agent` sent by the kubelet (e.g., User-Agent: kube-probe/1.29). + // For updated usage, please utilize knative.dev/networking/pkg/http/header.UserAgentKey and + // knative.dev/networking/pkg/http/header.KubeProbeUAPrefix KubeletProbeKey = "K-Kubelet-Probe" // RouteTagKey is the name of the header entry which has a tag name as value.