Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support configuration of the lifecycle image #2184

Open
braunsonm opened this issue Feb 26, 2024 · 6 comments
Open

Support configuration of the lifecycle image #2184

braunsonm opened this issue Feb 26, 2024 · 6 comments
Assignees
Labels
kind/bug Categorizes issue or PR as related to a bug. kind/good-first-issue Denotes an issue ready for a new contributor.

Comments

@braunsonm
Copy link

braunsonm commented Feb 26, 2024

When you run a build with the func CLI using your own builder it will attempt to pull the lifecycle binaries from quay.io. This may be because the builder is not trusted

However it doesn't seem that the func CLI respects the list of trusted builders that a user configures with the Pack CLI, and also does not allow configuration of this property itself. This means that at runtime func will attempt to pull the lifecycle from quay.io. The image that func pulls is hardcoded here:

var DefaultLifecycleImage = "quay.io/boson/lifecycle@sha256:f53fea9ec9188b92cab0b8a298ff852d76a6c2aaf56f968a08637e13de0e0c59"

This should allow configuration, or allow configuration of trusted builders so the built in lifecycle binaries can be used.

@lkingland
Copy link
Member

This seems like a bug to me. I will mark it as such.

It's perhaps worth mentioning that the builder lifecycle image is not intended as "hard-coded" (meaning an unchangable string built into the binary), but rather it is defaulted. This should be an optional user-modifiable setting.

@lkingland lkingland added kind/good-first-issue Denotes an issue ready for a new contributor. kind/bug Categorizes issue or PR as related to a bug. labels Mar 21, 2024
@braunsonm
Copy link
Author

I agree @lkingland however does func plan to follow the trusted builder methodology I linked from CNB? If so it should just use the included lifecycle binaries if the builder is trusted.

@EraKin575
Copy link

I would like to work on this issue!

@EraKin575
Copy link

/assign

Copy link
Contributor

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 16, 2024
@braunsonm
Copy link
Author

/remove-lifecycle stale

@knative-prow knative-prow bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. kind/good-first-issue Denotes an issue ready for a new contributor.
Projects
Status: 🔖 Next
Development

No branches or pull requests

3 participants