Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update release leads for Knative 1.16 #1620

Merged
merged 2 commits into from
Oct 10, 2024
Merged

Update release leads for Knative 1.16 #1620

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2ea678d
Update release leads for Knative 1.16
dsimansk Oct 10, 2024
0b49f93
Fix python install
dsimansk Oct 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/peribolos-schema-validate.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,11 +25,11 @@ jobs:
name: Check peribolos schema.
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
with:
fetch-depth: 0
lfs: true
- run: pip install strictyaml
- run: pip install strictyaml --break-system-packages
Copy link
Contributor

@skonto skonto Oct 10, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's open an issue to properly investigate this for all python deps? Options are:

  • use break-system-packages flag as a workaround
  • use virtual env
  • use system package manager or pipx

- name: Validate knative.yaml
run: python3 peribolos/validate-schema.py peribolos/knative.yaml
- name: Validate knative-extensions.yaml
Expand Down
7 changes: 6 additions & 1 deletion peribolos/knative-OWNERS_ALIASES
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,9 +62,14 @@ aliases:
- knative-test-reporter-robot
- nainaz
- psschwei
- retocode
- salaboy
- skonto
- upodroid
knative-release-leads: []
knative-release-leads:
- dsimansk
- retocode
- skonto
knative-robots:
- knative-automation
- knative-prow-releaser-robot
Expand Down
7 changes: 6 additions & 1 deletion peribolos/knative-extensions-OWNERS_ALIASES
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,9 +158,14 @@ aliases:
- knative-test-reporter-robot
- nainaz
- psschwei
- retocode
- salaboy
- skonto
- upodroid
knative-release-leads: []
knative-release-leads:
- dsimansk
- retocode
- skonto
knative-robots:
- knative-automation
- knative-prow-releaser-robot
Expand Down
5 changes: 4 additions & 1 deletion peribolos/knative-extensions.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -764,7 +764,10 @@ orgs:
Knative Release Leads:
privacy: closed
description: Active members of the Knative Release Leads rotation.
maintainers: []
maintainers:
- dsimansk
- retocode
- skonto
Productivity Leads:
#Using the same team name as below `Productivity WG Leads` puts peribolos in a weird state.
privacy: closed
Expand Down
5 changes: 4 additions & 1 deletion peribolos/knative.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -527,7 +527,10 @@ orgs:
Knative Release Leads:
privacy: closed
description: Active members of the Knative Release Leads rotation.
maintainers: []
maintainers:
- dsimansk
- retocode
- skonto
Productivity Leads:
#Using the same team name as below `Productivity WG Leads` puts peribolos in a weird state.
privacy: closed
Expand Down
Loading