Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rhuss and dsimansk as approvers to all kn plugins #1548

Closed
wants to merge 3 commits into from

Conversation

aliok
Copy link
Member

@aliok aliok commented Mar 29, 2024

Changes

  • Add rhuss and dsimansk as approvers to all kn plugins
  • This is necessary to remove some inactive approvers later on

Copy link

knative-prow bot commented Mar 29, 2024

@aliok: The label(s) kind/<kind> cannot be applied, because the repository doesn't have them.

In response to this:

Changes

  • Add rhuss and dsimansk as approvers to all kn plugins
  • This is necessary to remove some inactive approvers later on

/kind

Fixes #

Release Note


Docs


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 29, 2024
@aliok
Copy link
Member Author

aliok commented Mar 29, 2024

cc @rhuss @dsimansk

@knative-prow knative-prow bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 29, 2024
@rhuss
Copy link
Contributor

rhuss commented Mar 29, 2024

/approve
/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Mar 29, 2024
Copy link

knative-prow bot commented Mar 29, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aliok, rhuss

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot removed the lgtm Indicates that a PR is ready to be merged. label Mar 29, 2024
Copy link

knative-prow bot commented Mar 29, 2024

New changes are detected. LGTM label has been removed.

@knative-prow knative-prow bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 29, 2024
@psschwei
Copy link
Contributor

psschwei commented Apr 1, 2024

Are Roland / David covered as members of client-writers? For example, on quickstart we've explicitly listed them as one of the owners: https://github.com/knative-extensions/kn-plugin-quickstart/blob/main/OWNERS#L4

@dprotaso
Copy link
Member

dprotaso commented Apr 2, 2024

Yeah let's update the OWNER files in the various repos to add client-writers

@psschwei
Copy link
Contributor

psschwei commented Apr 2, 2024

I did a quick check of the kn-plugin repos and all looked to have client-writers in the owners file. So I think we're all good here.

@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 19, 2024
@davidhadas
Copy link
Contributor

Need rebase

@knative-prow-robot knative-prow-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 9, 2024
@aliok
Copy link
Member Author

aliok commented May 9, 2024

I did a quick check of the kn-plugin repos and all looked to have client-writers in the owners file. So I think we're all good here.

Thanks for checking. I am closing this one then.

@aliok
Copy link
Member Author

aliok commented May 9, 2024

/close

Copy link

knative-prow bot commented May 9, 2024

@aliok: Closed this PR.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@knative-prow knative-prow bot closed this May 9, 2024
@aliok aliok reopened this Jun 7, 2024
@aliok
Copy link
Member Author

aliok commented Jun 7, 2024

Maybe I misunderstood...

Can you have a look at

kn-plugin-diag-approvers:
- cdlliuy
- maximilien

Both names there are inactive and to be removed. Does that mean that leaving the group empty will work since rhuss and dsimansk are in the client-writers groups in all these repositories?

cc @dprotaso

@psschwei
Copy link
Contributor

psschwei commented Jun 7, 2024

Does that mean that leaving the group empty will work since rhuss and dsimansk are in the client-writers groups in all these repositories?

Yes, that's right

@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 4, 2024
@knative-prow-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@dprotaso dprotaso closed this Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants