Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hand off VMware trademark seat to Sameer #1385

Merged
merged 2 commits into from
Jul 11, 2023
Merged

Hand off VMware trademark seat to Sameer #1385

merged 2 commits into from
Jul 11, 2023

Conversation

evankanderson
Copy link
Member

Since Trademark seats are based on company affiliation, hand off the VMware seat to Sameer now that I've left VMware.

@knative-prow knative-prow bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 17, 2023
@evankanderson
Copy link
Member Author

/assign @xtreme-sameer-vohra

dprotaso
dprotaso reviewed Jun 19, 2023
View reviewed changes
peribolos/knative-OWNERS_ALIASES Outdated
@@ -156,7 +156,7 @@ aliases:
- psschwei
- zroubalik
trademark-committee:
- evankanderson
- xtreme-sameer-vohra
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

run codegen - sees like user names are sorted here

@dprotaso
Copy link
Member

dprotaso commented Jul 7, 2023

@evankanderson can you re-run codegen for this PR

@krsna-m
Copy link
Contributor

krsna-m commented Jul 11, 2023

@dprotaso Ran it for him see my commit. Hope @evankanderson is ok with that 🙏

@dprotaso
Copy link
Member

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jul 11, 2023
@evankanderson
Copy link
Member Author

Thanks, I think I was doing this on my windows machine where the autogen stuff is not always so happy.

/approve

@dprotaso
Copy link
Member

cc @knative/steering-committee for approval

@lance
Copy link
Member

lance commented Jul 11, 2023

/approve

@knative-prow
Copy link

knative-prow bot commented Jul 11, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, evankanderson, lance

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 11, 2023
@knative-prow knative-prow bot merged commit d5e8e47 into knative:main Jul 11, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dprotaso dprotaso dprotaso left review comments

@krsna-m krsna-m Awaiting requested review from krsna-m

@salaboy salaboy Awaiting requested review from salaboy

@smoser-ibm smoser-ibm Awaiting requested review from smoser-ibm

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@evankanderson @dprotaso @krsna-m @lance @xtreme-sameer-vohra