Skip to content
This repository has been archived by the owner on Mar 9, 2021. It is now read-only.

[kafka] bootstrapServers and Topics to accept arrays #85

Open
daisy-ycguo opened this issue Oct 23, 2020 · 1 comment
Open

[kafka] bootstrapServers and Topics to accept arrays #85

daisy-ycguo opened this issue Oct 23, 2020 · 1 comment
Assignees

Comments

@daisy-ycguo
Copy link
Member

daisy-ycguo commented Oct 23, 2020

Because kafkasource: change bootstrapServers and Topics to accept arrays is enabled in back-end, we shall modify client to support the changes.

Or else, we will get failure when creating a kafka source:

$./kn source kafka create mykafkasrc --servers my-cluster-kafka-bootstrap.kafka.svc:9092 --topics test-topic --consumergroup test-consumer-group
Error: cannot create KafkaSource 'mykafkasrc' in namespace 'default' because: admission webhook "defaulting.webhook.kafka.sources.knative.dev" denied the request: mutation failed: cannot decode incoming new object: json: cannot unmarshal string into Go struct field KafkaSourceSpec.spec.bootstrapServers of type []string
@navidshaikh
Copy link
Contributor

/assign

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants