Skip to content
This repository has been archived by the owner on Mar 9, 2021. It is now read-only.

[kn-admin] Refine subcommand wording #53

Open
zhanggbj opened this issue Jun 19, 2020 · 6 comments
Open

[kn-admin] Refine subcommand wording #53

zhanggbj opened this issue Jun 19, 2020 · 6 comments
Assignees

Comments

@zhanggbj
Copy link

Per discussion in
#40 (comment)

now in kn-admin, for different subcommand domain/registry, we're using add/update/etc for create/update actions. We should be consistent in kn-admin.

kn client has a story to use create/apply/remove. We can follow the same way to keep same user experience.

@chaozbj
Copy link
Contributor

chaozbj commented Jun 19, 2020

/assign
I would like to work on it.

@zhanggbj
Copy link
Author

@chaozbj
Could you please also take care of this #47 (comment)? Thanks!

@chaozbj
Copy link
Contributor

chaozbj commented Jun 23, 2020

@zhanggbj ok, no prblem

@chaozbj
Copy link
Contributor

chaozbj commented Jul 3, 2020

I would like to put it on hold because kn client has the similar feature and waits for implementation: knative/client#655, we will follow kn client to introduce create/apply/remove in our plugin.

@chaozbj
Copy link
Contributor

chaozbj commented Aug 4, 2020

The codes have been merged, will close it.
/close

@knative-prow-robot
Copy link

@chaozbj: You can't close an active issue/PR unless you authored it or you are a collaborator.

In response to this:

The codes have been merged, will close it.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants