-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Overwriting Base.info and Base.warn #27
Comments
From the documentation: "By default, Logging.info masks Base.info. However, if Base.info is called before using Logging, info will always refer to the Base version." Does this help? |
I think that adds confusion. I would like to import Logging into my package OnlineStats.jl, but I don't think I can add a dependency for which I have to warn users about overwriting Base methods. |
What about using different names like |
I think something like |
I wish that the package name were shorter, but I generally agree. I'll put forth a pull request which stops exporting all functions, and solicit feedback. @tkelman, any feedback on perhaps changing the name of this package to Log.info(...)
Log.warn(...)
Log.error(...) etc.? Do you think that would be acceptable, or is it taking too much liberty with the name? (I guess that would conflict with the same name being used in Base...) |
closes kmsquire#27 but is not backwards compatible
I would like to use Logging in a package, but
import Logging
overwrites Base.info and Base.warn, which I don't want to enforce on users. Could this be reconsidered?The text was updated successfully, but these errors were encountered: