Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mapping plausibility check fails for decimal degree #60

Open
jmhuss opened this issue Jan 28, 2021 · 2 comments
Open

Mapping plausibility check fails for decimal degree #60

jmhuss opened this issue Jan 28, 2021 · 2 comments

Comments

@jmhuss
Copy link
Contributor

jmhuss commented Jan 28, 2021

If decimal degree are used for x_ and y_coord to map locations in the location_library, the check for plausibility fails since it misinterprets the values (as meter? dy does not match the distance in meter, though), raising an error.
Input from config file:

    exmpl:
      long name: exmpl
      loc_type: cold
      x_coord:
      - 11.581928
      - 11.581928
      y_coord:
      - 49.926404
      - 49.926312
      z_coord:
      - -0.1
      - -0.1
      LAF:
      - 73.0314
      - 82.2255

Error:

ValueError: Mapping problem detected for exmpl. Inferred data spacing is
dx = 0.0
dy = -2.6285714284313145e-06
dz = 0.0
total = 2.6285714284313145e-06
dLAF = [0.2542]

Including a flag to disable the check globally might be the easiest fix (if there is not already one that I am not aware of), else checking or asking for coordinate system.

@klapo
Copy link
Owner

klapo commented Feb 1, 2021

Thanks for raising this issue!

What sort of information would need to be included to provide a non-straight-line mapping like along a column? I haven't implemented a column geometry before. If we can get a prototype going I could see pyfocs directly mapping columns. If that turns out to be too complex to succinctly encapsulate in the config location library, I would instead make a flag for disabling the distance checking.

@jmhuss
Copy link
Contributor Author

jmhuss commented Feb 2, 2021

My issue was not about a column deployment but about a 'regular' geometry, just with x and y coordinates in decimal degree instead of UTM coordinates, which can't be directly interpreted as meter.
If a conversion for distance checking is beyond feasible I'm in favor of a flag to globally disable the distance check for the whole config file so that one does not need to add a line to each section, stating that it shall be skipped in the check.

But answering your question regarding the column:
I can't see a column distance check without the user handing over the diameter/circumference of the column and the distance between the coils so that pyfocs can convert the LAF into an effective vertical distance and compare it to dz.
I'm not sure, though, if that saves more effort than just checking the result manually. So I agree a flag might be the way to go.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants