Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable ec_add / ec_mul #1398

Merged
merged 15 commits into from
Sep 24, 2024

update from code review

d9cae56
Select commit
Loading
Failed to load commit list.
Merged

feat: enable ec_add / ec_mul #1398

update from code review
d9cae56
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Sep 24, 2024 in 0s

61.8% (-1.3%) compared to c7896d0

View this Pull Request on Codecov

61.8% (-1.3%) compared to c7896d0

Details

Codecov Report

Attention: Patch coverage is 10.52632% with 17 lines in your changes missing coverage. Please review.

Project coverage is 61.8%. Comparing base (c7896d0) to head (d9cae56).
Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
src/kakarot/interpreter.cairo 0.0% 11 Missing ⚠️
src/kakarot/precompiles/precompiles.cairo 14.2% 6 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##            main   #1398     +/-   ##
=======================================
- Coverage   63.1%   61.8%   -1.3%     
=======================================
  Files         49      44      -5     
  Lines       8332    8169    -163     
=======================================
- Hits        5260    5055    -205     
- Misses      3072    3114     +42     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.