-
Notifications
You must be signed in to change notification settings - Fork 304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: update doc [2] #1363
Comments
This comment was marked as abuse.
This comment was marked as abuse.
Hey @ShantelPeters! |
ClementWalter
moved this from 🆕 Backlog
to 📅 Next sprint
in Kakarot's Project Management
Oct 25, 2024
ClementWalter
changed the title
doc: beware of the usage of msg.value and delegatecallCairo
doc: update doc
Oct 25, 2024
matthieuauger
pushed a commit
to matthieuauger/kakarot
that referenced
this issue
Nov 9, 2024
* fix: check whitelisted tx * feat: unit test toTypedEthTx with hash not whitelisted * fix: WHITE_LISTED_EIP_155_TRANSACTION_HASHES indexer env * fix: custom error for v !== 27 and v!==28 * fix: fmt * fix: remove WHITE_LISTED_EIP_155_TRANSACTION_HASHES check * fix: remove WHITE_LISTED_EIP_155_TRANSACTION_HASHES * fix: error message
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Feature Request
What
General update, and especially this:
The following snippet surprised me first
as the
msg.value
was sent 2 times. It's actually the intended behavior as:msg.value
sends ETH to the contractdelegatecallCairo
sends ETH from the caller oftransfer
This is however worth noticing in the doc
How
PR in https://github.com/kkrt-labs/kakarot-docs
The text was updated successfully, but these errors were encountered: