We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Currently, the Kakarot contract is one single file with all the entry points.
As the contract gets bigger, it becomes difficult to read and understand what does what.
Create several sub contract with meaningful entrypoints
keep in the main kakarot.cairo only the constructor and imports all the functions defined in the other sub contracts (presets)
The simple getter and setter defined in the library.cairo should also be directly inlined in the corresponding entry points
library.cairo
(e.g.
@view func get_native_token{syscall_ptr: felt*, pedersen_ptr: HashBuiltin*, range_check_ptr}() -> ( native_token_address: felt ) { return Kakarot.get_native_token(); }
should be inlined in Kakarot.get_native_token)
Kakarot.get_native_token
The text was updated successfully, but these errors were encountered:
This is partially done (see #1352) we could do the others as well. tbd
Sorry, something went wrong.
eugypalu
No branches or pull requests
Why
Currently, the Kakarot contract is one single file with all the entry points.
As the contract gets bigger, it becomes difficult to read and understand what does what.
What
Create several sub contract with meaningful entrypoints
keep in the main kakarot.cairo only the constructor and imports all the functions defined in the other sub contracts (presets)
The simple getter and setter defined in the
library.cairo
should also be directly inlined in the corresponding entry points(e.g.
should be inlined in
Kakarot.get_native_token
)The text was updated successfully, but these errors were encountered: