Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: create a MerkleProofLib Cairo Module #1245

Closed
Eikix opened this issue Jul 1, 2024 · 4 comments
Closed

feat: create a MerkleProofLib Cairo Module #1245

Eikix opened this issue Jul 1, 2024 · 4 comments

Comments

@Eikix
Copy link
Member

Eikix commented Jul 1, 2024

Feature Request

As part of the Cairo Module track, we want to create new Cairo Modules that unlock usecases on Kakarot Sepolia and iteratively build a vibrant ecosystem of ZK-optimized modules to augment our EVM.

Describe the Feature Request

Needs further scoping cc @enitrat

Create a MerkleProofLib Cairo Module, inspired by Solady's optimized https://github.com/Vectorized/solady/blob/main/src/utils/MerkleProofLib.sol or https://github.com/huff-language/huffmate/blob/main/src/utils/MerkleProofLib.huff to enable developers to verify Merkle inclusion proofs in Kakarot

Describe Preferred Solution

  • Check if a Cairo library already exists for Merkle inclusion
  • Scope further the issue by identifying sub-libraries to implement first
@augustin-v
Copy link

Hello! first-timer here, I'd love to work on this

Copy link

onlydustapp bot commented Jul 9, 2024

Hey @augustin-v!
Thanks for showing interest.
We've created an application for you to contribute to Kakarot zkEVM.
Go check it out on OnlyDust!

@enitrat
Copy link
Collaborator

enitrat commented Jul 10, 2024

@Eikix what's the concrete use case as of now? If not, this is going to be stale for a while until there is demand for it.

@Eikix
Copy link
Member Author

Eikix commented Jul 12, 2024

Concrete use case would be to build a toy app that checks the inclusion of an element in a Merkle tree
It'd probably use https://github.com/keep-starknet-strange/alexandria/tree/main/packages/merkle_tree

@ClementWalter ClementWalter closed this as not planned Won't fix, can't repro, duplicate, stale Oct 25, 2024
@github-project-automation github-project-automation bot moved this from 🆕 Backlog to ✅ Done in Kakarot's Project Management Oct 25, 2024
matthieuauger pushed a commit to matthieuauger/kakarot that referenced this issue Nov 9, 2024
* bump reth to v1.0.0

* clean up

* bump mongo db crate

* bump katana

* bump test container

* fix katana NonZero issue

* clean up

* fix

* bump ef test

* Update src/eth_provider/error.rs

Co-authored-by: greged93 <[email protected]>

* Update src/test_utils/mongo/mod.rs

Co-authored-by: greged93 <[email protected]>

* Update src/test_utils/katana/mod.rs

Co-authored-by: greged93 <[email protected]>

* Update src/test_utils/mongo/mod.rs

Co-authored-by: greged93 <[email protected]>

* cleanup

* fix naming

---------

Co-authored-by: greged93 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

4 participants