Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add an init method to the interpreter to assign opcode to address #1197

Closed
ClementWalter opened this issue Jun 10, 2024 · 0 comments
Closed

Comments

@ClementWalter
Copy link
Member

ClementWalter commented Jun 10, 2024

Feature Request

Describe the Feature Request

Currently, the mapping address => opcode implementation is hardcoded in the big jumptable of the interpreter.
It shouldn't cost a lot (few hundred steps) to use instead of segment of opcode codeoffset stored in the evm object.
The default initialization would set the current eth mainnet default layout.
Adding an opcode would then only consist in doing an assert evm.opcodes[index] = impl.

Related Code

interpreter.cairo

@ClementWalter ClementWalter closed this as not planned Won't fix, can't repro, duplicate, stale Oct 21, 2024
@github-project-automation github-project-automation bot moved this from 🆕 Backlog to ✅ Done in Kakarot's Project Management Oct 21, 2024
matthieuauger pushed a commit to matthieuauger/kakarot that referenced this issue Nov 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

1 participant