Fix pr review and scarb not found

kkrt-labs · Aug 28, 2024 · 5530b7d · 5530b7d
1 parent 6dcf858
commit 5530b7d
Show file tree

Hide file tree

Showing 5 changed files with 10 additions and 9 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -154,6 +154,7 @@ jobs:
         uses: foundry-rs/foundry-toolchain@v1
         with:
           version: nightly
+      - uses: asdf-vm/actions/install@v3
       - name: Load cached katana
         id: cached-katana
         uses: actions/cache@v4

diff --git a/Makefile b/Makefile
@@ -38,15 +38,15 @@ fetch-ssj-artifacts:
 setup: fetch-ssj-artifacts
 	poetry install
 
-test: build-sol deploy
+test: deploy
 	poetry run pytest tests/src -m "not NoCI" --log-cli-level=INFO -n logical --seed 42
 	poetry run pytest tests/end_to_end --seed 42
 
 test-unit: build-sol
 	poetry run pytest tests/src -m "not NoCI" -n logical --seed 42
 
 # run make run-nodes in other terminal
-test-end-to-end: build-sol deploy
+test-end-to-end: deploy
 	poetry run pytest tests/end_to_end --seed 42
 
 deploy: build build-sol

diff --git a/cairo1_contracts/utils/Scarb.lock b/cairo1_contracts/utils/Scarb.lock
@@ -2,5 +2,5 @@
 version = 1
 
 [[package]]
-name = "library_call"
+name = "utils"
 version = "0.1.0"
diff --git a/cairo1_contracts/utils/Scarb.toml b/cairo1_contracts/utils/Scarb.toml
@@ -1,5 +1,5 @@
 [package]
-name = "library_call"
+name = "utils"
 version = "0.1.0"
 edition = "2023_11"
 

diff --git a/solidity_contracts/src/CairoPrecompiles/EthStarknetBridge.sol b/solidity_contracts/src/CairoPrecompiles/EthStarknetBridge.sol
@@ -6,8 +6,12 @@ import {CairoLib} from "kakarot-lib/CairoLib.sol";
 using CairoLib for uint256;
 
 contract EthStarknetBridge {
+    /// @dev The cairo contract to call
+    uint256 constant starknetEth = 0x49D36570D4E46F48E99674BD3FCC84644DDD6B96F7C741B1562B82F9E004DC7;
+    uint256 constant TRANSFER_SELECTOR = uint256(keccak256("transfer")) % 2 ** 250;
+
     // State variable to store the owner of the contract
-    address public owner;
+    address immutable owner;
 
     // Constructor sets the owner of the contract
     constructor() {
@@ -20,10 +24,6 @@ contract EthStarknetBridge {
         _;
     }
 
-    /// @dev The cairo contract to call
-    uint256 constant starknetEth = 0x49D36570D4E46F48E99674BD3FCC84644DDD6B96F7C741B1562B82F9E004DC7;
-    uint256 constant TRANSFER_SELECTOR = uint256(keccak256("transfer")) % 2 ** 250;
-
     /// @notice Withdraws ETH from the contract to a Starknet address
     function withdraw(uint256 toStarknetAddress) external onlyOwner {
         uint256 balance = address(this).balance;