Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Oba <[email protected]>
  • Loading branch information
enitrat and obatirou committed Sep 17, 2024
1 parent 8a78323 commit a7ced20
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -15,10 +15,10 @@ pub impl StopAndArithmeticOperations of StopAndArithmeticOperationsTrait {
/// Halts the execution of the current program.
/// # Specification: https://www.evm.codes/#00?fork=shanghai
fn exec_stop(ref self: VM) {
// return_data stored the return_data for the last executed sub context
// see CALLs opcodes. When we run the STOP opcode, we stop the current
// return_data store the return_data for the last executed sub context
// see CALLs opcodes. When it runs the STOP opcode, it stops the current
// execution context with *no* return data (unlike RETURN and REVERT).
// hence we just clear the return_data and stop.
// hence it just clear the return_data and stop.
self.return_data = [].span();
self.stop();
}
Expand Down
2 changes: 1 addition & 1 deletion crates/evm/src/instructions/system_operations.cairo
Original file line number Diff line number Diff line change
Expand Up @@ -541,7 +541,7 @@ mod tests {
}

#[test]
fn test_exec_staticcall() {
fn test_should_fail_exec_staticcall() {
// Given

// Set vm bytecode
Expand Down

0 comments on commit a7ced20

Please sign in to comment.