Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Channel buffer missing Key #373

Merged
merged 3 commits into from
Jan 17, 2024
Merged

Channel buffer missing Key #373

merged 3 commits into from
Jan 17, 2024

Conversation

klexas
Copy link
Contributor

@klexas klexas commented Jan 7, 2024

Key not being passed through while creating channel buffers.

Key not being passed through while creating channel buffers.
@brunnre8
Copy link
Contributor

brunnre8 commented Jan 7, 2024

This is missing the corresponding changes to the docs.

@klexas
Copy link
Contributor Author

klexas commented Jan 7, 2024

This is missing the corresponding changes to the docs.

You're right, I missed that, funny enough the docs had the key mentioned for the join([key]) method already. Updated.

@klexas klexas closed this Jan 7, 2024
@klexas klexas reopened this Jan 7, 2024
docs/clientapi.md Outdated Show resolved Hide resolved
@MaxLeiter MaxLeiter merged commit cd7ece4 into kiwiirc:master Jan 17, 2024
4 checks passed
@klexas klexas deleted the patch-1 branch September 28, 2024 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants