Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preparing a new version (3.1.0) - Upgrading to Xcode 11 #719

Open
ecaselles opened this issue Jan 30, 2020 · 4 comments
Open

Preparing a new version (3.1.0) - Upgrading to Xcode 11 #719

ecaselles opened this issue Jan 30, 2020 · 4 comments

Comments

@ecaselles
Copy link
Member

ecaselles commented Jan 30, 2020

After having managed to skip Xcode 10 😅, Xcode 11 is throwing a few warnings when building and using Kiwi.

I am putting together a new version to support Xcode 11 and while doing that, I will be reviewing any other PR that seems almost ready to go in.

If you have any changes or PRs that you would like to get into the release, please ping them here and we can work together.

Thanks!

@ecaselles ecaselles changed the title Preparing a new version - Upgrading to Xcode 11 Preparing a new version (3.1.0) - Upgrading to Xcode 11 Jan 31, 2020
@bamx23
Copy link
Contributor

bamx23 commented Jun 24, 2020

Maybe it is better to check if everything OK with Xcode 12 and make a release?

@ecaselles
Copy link
Member Author

ecaselles commented Jun 27, 2020

Hey @bamx23! Yes, that make sense. Have you checked it by any chance? Are there any major problems?

If there are issues and they don't seem immediate to fix, I would still try to release this version supporting Xcode 11 and then start working on a new one for Xcode 12. Does that make sense?

@bamx23
Copy link
Contributor

bamx23 commented Jun 27, 2020

I haven't checked Xcode 12 integration yet, but I'll try it next week.

But I think it's a good idea to release current changes anyway because I still face the same problems with the issue I fixed in #716 sometimes.

@bamx23
Copy link
Contributor

bamx23 commented Jul 14, 2020

I've been working with unit tests and Kiwi in Xcode 12 for about a week without any problems. No new warnings either.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants