Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable the percentage limit feature #7

Merged
merged 1 commit into from
Oct 2, 2023

Conversation

felix021
Copy link
Contributor

@felix021 felix021 commented Sep 27, 2023

What type of PR is this?

feat

Check the PR title.

  • This PR title match the format: <type>(optional scope): <description>
  • The description of this PR title is user-oriented and clear enough for others to understand.
  • Attach the PR updating the user documentation if the current PR requires user awareness at the usage level. User docs repo

(Optional) Translate the PR title into Chinese.

(Optional) More detailed description for this PR(en: English/zh: Chinese).

en: Kitex v0.7.2 provides a new feature for precisely limiting the percentage of retry requests, which should be more practical than the old way (depending on the error rate), especially for backup request. Optimize the document by the way.
zh(optional):

(Optional) Which issue(s) this PR fixes:

(optional) The PR that updates user documentation:

README.md Show resolved Hide resolved
@felix021 felix021 changed the title feature: enable the percentage limit feature provided by v0.7.2 feat: enable the percentage limit feature Sep 27, 2023
@whalecold
Copy link
Member

/lgtm

@whalecold
Copy link
Member

/approve

@bytedance-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: felix021, whalecold

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@felix021 felix021 merged commit d51736c into kitex-contrib:main Oct 2, 2023
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants