-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(limiter): implement the limiter config #4
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
license-eye has totally checked 34 files.
Valid | Invalid | Ignored | Fixed |
---|---|---|---|
14 | 1 | 19 | 0 |
Click to see the invalid file list
- server/limiter.go
a76d265
to
c190c03
Compare
server/suit.go
Outdated
) | ||
|
||
const ( | ||
limiterConfigName = "limiter_config" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The config names can be simplified (like limit, retry, ...), no need to be the same as Bytedance internal (I was expecting this project to use configmanager when writing the proposal).
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: felix021, whalecold The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
Check the PR title.
(Optional) Translate the PR title into Chinese.
(Optional) More detailed description for this PR(en: English/zh: Chinese).
en:
zh(optional):
(Optional) Which issue(s) this PR fixes:
cloudwego/kitex#975
(optional) The PR that updates user documentation: