Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(prob): support protocol probing #92

Merged
merged 4 commits into from
May 15, 2024

Conversation

whalecold
Copy link
Member

What type of PR is this?

feat

Check the PR title.

  • This PR title match the format: <type>(optional scope): <description>
  • The description of this PR title is user-oriented and clear enough for others to understand.
  • Attach the PR updating the user documentation if the current PR requires user awareness at the usage level. User docs repo

(Optional) Translate the PR title into Chinese.

支持协议嗅探,同时支持 dubbo 和原生的 thrift

(Optional) More detailed description for this PR(en: English/zh: Chinese).

en:
zh(optional):

(Optional) Which issue(s) this PR fixes:

#91

(optional) The PR that updates user documentation:

@CLAassistant
Copy link

CLAassistant commented May 15, 2024

CLA assistant check
All committers have signed the CLA.

README.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@DMwangnima DMwangnima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTW. Could you add crosstest to https://github.com/kitex-contrib/codec-dubbo-tests ?

pkg/server_trans_handler_factory.go Outdated Show resolved Hide resolved
pkg/server_trans_handler_factory.go Outdated Show resolved Hide resolved
README_ENG.md Outdated Show resolved Hide resolved
@whalecold
Copy link
Member Author

whalecold commented May 15, 2024

BTW. Could you add crosstest to https://github.com/kitex-contrib/codec-dubbo-tests ?

Ok, I will do that later.

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: DMwangnima, whalecold

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@DMwangnima DMwangnima merged commit 60d04fd into kitex-contrib:main May 15, 2024
15 of 16 checks passed
@whalecold whalecold deleted the feat/prob branch May 15, 2024 09:50
@DMwangnima DMwangnima mentioned this pull request May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants